westonpace commented on code in PR #13969:
URL: https://github.com/apache/arrow/pull/13969#discussion_r955506618
##########
cpp/src/arrow/engine/substrait/function_test.cc:
##########
@@ -487,7 +497,13 @@ TEST(FunctionMapping, AggregateCases) {
float64(),
"[2]",
"[1.5, 3]",
- float64()}};
+ float64()},
+ {{kSubstraitAggregateGenericFunctionsUri, "count"},
+ {"[1, 2, 30]"},
+ {int8()},
+ "[3]",
+ "[2, 1]",
+ int64()}};
Review Comment:
Unfortunately, the count function takes in a [single optional enum
argument](https://github.com/substrait-io/substrait/blob/main/extensions/functions_aggregate_generic.yaml#L8).
I have no idea what the purpose of this argument is. However, in Substrait,
"optional arguments" should still be included in the protobuf.
I realize now that I did not account for this in the other aggregate
functions too :(.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
