HaoYang670 commented on code in PR #3258:
URL: https://github.com/apache/arrow-datafusion/pull/3258#discussion_r956535260
##########
datafusion/core/src/datasource/view.rs:
##########
@@ -342,6 +355,65 @@ mod tests {
Ok(())
}
+ #[tokio::test]
+ async fn query_view_with_filter_and_limit() -> Result<()> {
+ let session_ctx = SessionContext::with_config(
+ SessionConfig::new().with_information_schema(true),
+ );
+
+ session_ctx
+ .sql("CREATE TABLE abc AS VALUES (1,2,3), (4,5,6), (7,8,9)")
+ .await?
+ .collect()
+ .await?;
+
+ let view_sql = "CREATE VIEW xyz AS SELECT column1, column2 FROM abc";
+ session_ctx.sql(view_sql).await?.collect().await?;
+
+ let results = session_ctx.sql("SELECT * FROM information_schema.tables
WHERE table_type='VIEW' AND table_name = 'xyz'").await?.collect().await?;
+ assert_eq!(results[0].num_rows(), 1);
+
+ let result_plan = session_ctx
+ .sql("EXPLAIN CREATE VIEW efg as SELECT column1 FROM xyz WHERE
column2 % 2 = 0 OFFSET 1 LIMIT 2")
Review Comment:
> We can see that the filter and limit are added into the logical plan
though so I think this is good enough for this PR.
I guess what we do in this PR is to add the `limit` and `filter` information
into the `TableScan`. However, I can't find a way to test whether it works
properly. Could you help me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
