tustvold commented on code in PR #2588:
URL: https://github.com/apache/arrow-rs/pull/2588#discussion_r956547882
##########
arrow/src/util/display.rs:
##########
@@ -235,6 +235,22 @@ macro_rules! make_string_from_list {
}};
}
+macro_rules! make_string_from_large_list {
+ ($column: ident, $row: ident) => {{
+ let list = $column
+ .as_any()
+ .downcast_ref::<array::LargeListArray>()
+ .ok_or(ArrowError::InvalidArgumentError(format!(
+ "Repl error: could not convert large list column to list
array."
+ )))?
+ .value($row);
+ let string_values = (0..list.len())
+ .map(|i| array_value_to_string(&list.clone(), i))
Review Comment:
Why the clone?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
