eitsupi commented on code in PR #13677:
URL: https://github.com/apache/arrow/pull/13677#discussion_r956558805
##########
python/pyarrow/tests/test_dataset.py:
##########
@@ -4192,27 +4192,27 @@ def test_write_table_multiple_fragments(tempdir):
# Table with multiple batches written as single Fragment by default
base_dir = tempdir / 'single'
ds.write_dataset(table, base_dir, format="feather")
- assert set(base_dir.rglob("*")) == set([base_dir / "part-0.feather"])
+ assert set(base_dir.rglob("*")) == set([base_dir / "part-0.arrow"])
assert ds.dataset(base_dir, format="ipc").to_table().equals(table)
# Same for single-element list of Table
base_dir = tempdir / 'single-list'
ds.write_dataset([table], base_dir, format="feather")
- assert set(base_dir.rglob("*")) == set([base_dir / "part-0.feather"])
+ assert set(base_dir.rglob("*")) == set([base_dir / "part-0.arrow"])
assert ds.dataset(base_dir, format="ipc").to_table().equals(table)
# Provide list of batches to write multiple fragments
base_dir = tempdir / 'multiple'
ds.write_dataset(table.to_batches(), base_dir, format="feather")
assert set(base_dir.rglob("*")) == set(
- [base_dir / "part-0.feather"])
+ [base_dir / "part-0.arrow"])
Review Comment:
Hmmm, I wonder if it is worth complicating the source code just to keep the
`.feather` extension. (Of course, I'm not the maintainer, so if that's ok with
the maintainer, fine.)
Considering that the extension can be changed to any extension by setting
the `basename_template` option (as @westonpace says), I think there is no need
to treat only the `"feather"` case specially here.
I want to emphasize that it is hard to understand the relationship between
IPC files and Feather files anyway.
For example, in Julia, if we want to read an IPC file, I need Arrow.jl, but
if I want to read a Feather V1 file, we need the Feather.jl library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
