tustvold commented on code in PR #2592:
URL: https://github.com/apache/arrow-rs/pull/2592#discussion_r956578260
##########
arrow/src/compute/kernels/cast.rs:
##########
@@ -2355,7 +2355,7 @@ where
let values = cast_values.as_any().downcast_ref::<StringArray>().unwrap();
let keys_builder = PrimitiveBuilder::<K>::with_capacity(values.len());
- let values_builder = StringBuilder::new(values.len());
+ let values_builder = StringBuilder::with_capacity(1024, values.len());
Review Comment:
In this case I'd be tempted to just go with new, this estimate isn't
obviously better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
