nevi-me edited a comment on pull request #8199: URL: https://github.com/apache/arrow/pull/8199#issuecomment-699469333
Apologies for the back & forth. Just checked out the PR and ran a clippy check. The PR and a few others before have introduced a few warnings and errors. I find clearing lints helps me learn interesting shortcuts along the line, @jorgecarleitao do you mind checking the lints and clearing them (even those beyond the scope of this PR if you'd like)? The most interesting for me was learning that to clone an optional reference (`let some_struct_ref = Option<&MyStruct>`), you can use `let some_struct: Option<MyStruct> = some_struct_ref.cloned()` instead of `some_struct_ref.map(|s| s.clone())`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
