nevi-me commented on pull request #6770:
URL: https://github.com/apache/arrow/pull/6770#issuecomment-699481913


   > @nevi-me I am happy to help but I couldn't see any changes to the filter 
kernel in this PR; have I misunderstood your message?
   
   Apologies, this PR came from a fork that UrbanLogiq maintain, so I think 
they had worked on list filters for their purposes, and then initially included 
those commits in this PR, but eventually reversed them.
   
   I think it's still good to incorporate those changes, as the relevant JIRA 
has been open for a while (ARROW-5350).
   
   I've extracted the changes and pushed them to my fork at 
https://github.com/nevi-me/arrow/commit/4c11f46a62e770ff3c56d3898daf429099a8cb1a.
 You'll see that I commented out the filter on lists, as I couldn't figure out 
how to make them work with `FilterContext` as mentioned.
   
   There's already some tests, so looks like a solid base to start from. You 
can copy the changes from my commit, or push into my ARROW-5350 branch; 
either's fine with me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to