lidavidm commented on issue #84: URL: https://github.com/apache/arrow-adbc/issues/84#issuecomment-1230183851
We could add a build option or just produce both variants? But I would rather leave it to the application whether they choose to link it or load it at runtime, yes. > Apart from that, `AdbcLoadDriver` looks like a potentially handy workhorse function. Does it take full paths to DLLs? > > (if so, should probably switch to `LoadLibraryExW` on Windows and/or expose a `const wchar_t*`-taking variant?) #57 refactors things a bit so you can load things yourself and still use the driver manager interfaces. That said it'd be good to make those improvements. > BTW, should we remove AdbcLoadDriver()? https://github.com/apache/arrow-adbc/blob/main/c/driver_manager/adbc_driver_manager.cc#L600 I plan to use `AdbcLoadDriver` for Arrow Dataset integration, at least (since runtime loading makes more sense to me there than trying to bundle everything into Arrow itself), though I suppose we'll have to figure out how best to make that work with Python/R/... bindings -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
