kou commented on PR #90: URL: https://github.com/apache/arrow-adbc/pull/90#issuecomment-1230338351
I think that "trying to build up the CMake config from first principles" is better for maintainability. I think that ADBC can be built with simple build config. (Arrow needs complex build config because it has many components, depends on many libraries and so on...) Arrow's common CMake modules have some helpful features but it's complex. We'll refactor Arrow's CMake modules in the future Arrow development. Backporting changes from Arrow to ADBC may be difficult. FYI: The changes for `BuildUtils.cmake` in this pull request is backported from https://github.com/apache/arrow/pull/13892 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
