andygrove commented on code in PR #3290:
URL: https://github.com/apache/arrow-datafusion/pull/3290#discussion_r957765787
##########
benchmarks/src/bin/tpch.rs:
##########
@@ -1022,9 +1024,10 @@ mod tests {
ctx.register_table(table, Arc::new(provider))?;
}
- let plans = create_logical_plans(&ctx, n)?;
- for plan in plans {
- execute_query(&ctx, &plan, false).await?;
Review Comment:
Why not just pass `sql` into this method instead of `plan`. Inside the
method you can add a couple lines to get the plan from the SQL. This will
retain the existing debug logging.
```
let plan = ctx.sql(sql).await?;
let plan = plan.to_logical_plan()?;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
