westonpace commented on PR #13830:
URL: https://github.com/apache/arrow/pull/13830#issuecomment-1230827719
> please comment on the interface
I like the python API. As for the C++:
* `get_read_range` and `set_bounds` are inconsistent. They should be
`get_xyz` and `set_xyz` although...
* I think `Fragment` should be immutable. Instead of `set_bounds` can we
have a `Slice` method like we have in python that returns a new `Fragment`
(admittedly, since `Fragment` is an abstract class, we might need to introduce
a `Clone`, but I think that's ok)?
* Why do I need to supply a range to `OpenRange` if the object already has
a range as an instance variable? For that matter, why do I need `OpenRange` at
all. Wouldn't the normal `Open` automatically open a range view?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
