thisisnic commented on PR #13786: URL: https://github.com/apache/arrow/pull/13786#issuecomment-1231659849
> I think you nailed it - the `mutate()` tests are about matching dplyr's functionality (e.g., they will fail if dplyr changes something and makes this code out of sync); the `expand_across()` tests are about `expand_across()`; and we need both. > > I would personally just copy/paste all the places where `across()` appears in your mutate tests but `expect_identical(expand_across(quo(across(...)), ...)` instead. If you feel this is out of scope for this PR I am OK with that, too (but I think it's worth trying). I absolutely agree with the argument that this is a big function and it'd be worth having tests for it, though also wondering if copying and pasting every single test might be a bit excessive - we don't necessarily test intermediate functions in some of our other dplyr verbs (though perhaps we should). I might just check with @nealrichardson or @jonkeane to see if they see any middle ground in what needs to be tested - if there isn't, I'm happy to copy and paste everything and approach it that way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
