pitrou commented on code in PR #13989:
URL: https://github.com/apache/arrow/pull/13989#discussion_r958505592
##########
python/pyarrow/array.pxi:
##########
@@ -2478,6 +2478,53 @@ cdef class DictionaryArray(Array):
return self._indices
+ @staticmethod
+ def from_buffers(DataType type, int64_t length, buffers, Array dictionary,
+ int64_t null_count=-1, int64_t offset=0):
+ """
+ Construct a DictionaryArray from buffers.
+
+ Parameters
+ ----------
+ type : pyarrow.DataType
+ length : int
+ The number of values in the array.
+ buffers : List[Buffer]
+ The buffers backing this array.
+ dictionary : pyarrow.Array, ndarray or pandas.Series
+ The array of values referenced by the indices.
+ null_count : int, default -1
+ The number of null entries in the array. Negative value means that
Review Comment:
```suggestion
The number of null entries in the indices array. Negative value
means that
```
##########
python/pyarrow/array.pxi:
##########
@@ -2478,6 +2478,53 @@ cdef class DictionaryArray(Array):
return self._indices
+ @staticmethod
+ def from_buffers(DataType type, int64_t length, buffers, Array dictionary,
+ int64_t null_count=-1, int64_t offset=0):
+ """
+ Construct a DictionaryArray from buffers.
+
+ Parameters
+ ----------
+ type : pyarrow.DataType
+ length : int
+ The number of values in the array.
+ buffers : List[Buffer]
+ The buffers backing this array.
Review Comment:
Would this be less ambiguous?
```suggestion
The buffers backing the indices array.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
