westonpace commented on code in PR #13401:
URL: https://github.com/apache/arrow/pull/13401#discussion_r958604739
##########
cpp/src/arrow/engine/substrait/plan_internal.cc:
##########
@@ -133,5 +136,18 @@ Result<ExtensionSet> GetExtensionSetFromPlan(const
substrait::Plan& plan,
registry);
}
+Result<std::unique_ptr<substrait::Plan>> PlanToProto(
Review Comment:
That makes sense. So the root problem is that a relation and a plan are
both represented in Acero by `compute::Declaration` and so there is ambiguity.
I think the name `PlanToProto` is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
