pitrou commented on code in PR #13997:
URL: https://github.com/apache/arrow/pull/13997#discussion_r958694116
##########
cpp/src/parquet/column_reader.h:
##########
@@ -218,10 +218,13 @@ class TypedColumnReader : public ColumnReader {
int64_t valid_bits_offset, int64_t*
levels_read,
int64_t* values_read, int64_t* null_count) =
0;
- // Skip reading values.
+ // Skip reading values. This method will work for both repeated and
+ // non-repeated fields. Note that this method is skipping values and not
+ // records. This distinction is important for repeated fields, meaning that
+ // we are not skipping over the values to the next record. We are skipping
+ // through them. So after the skip the iterator could be in the middle of a
Review Comment:
Thanks for the update. This reads better, but I'm afraid the distinction
between "skipping over" and "skipping through" is not clear to me. Could you
perhaps try to explain better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
