andygrove commented on a change in pull request #8285:
URL: https://github.com/apache/arrow/pull/8285#discussion_r495582607
##########
File path: rust/datafusion/benches/sort_limit_query_sql.rs
##########
@@ -66,21 +66,23 @@ fn create_context() -> ExecutionContext {
)
.unwrap();
- let mem_table = MemTable::load(&csv).unwrap();
+ // let mem_table = MemTable::load(&csv).await.unwrap();
+ //
+ // // create local execution context
+ // let ctx = ExecutionContext::new();
+ // ctx.state.config.concurrency = 1;
+ // ctx.register_table("aggregate_test_100", Box::new(mem_table));
+ // Arc::new(Mutex::new(ctx))
- // create local execution context
- let mut ctx = ExecutionContext::new();
- ctx.state.config.concurrency = 1;
- ctx.register_table("aggregate_test_100", Box::new(mem_table));
- ctx
+ unimplemented!()
Review comment:
The issue was that I couldn't call async code from criterion so I had to
create a separate tokio runtime and block on some async code. I expect that
there may be a cleaner way to do this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
