andygrove commented on code in PR #3301:
URL: https://github.com/apache/arrow-datafusion/pull/3301#discussion_r959008005
##########
datafusion/physical-expr/src/planner.rs:
##########
@@ -83,6 +83,84 @@ pub fn create_physical_expr(
}
}
}
+ Expr::IsTrue(expr) => {
+ let binary_op = binary_expr(
+ expr.as_ref().clone(),
+ Operator::IsNotDistinctFrom,
+ Expr::Literal(ScalarValue::Boolean(Some(true))),
Review Comment:
Now that we have the specific `IsTrue` expressions in the logical plan, we
can update the `TypeCoercion` optimizer rule to validate (or try and coerce)
the types before we get to the physical planning phase. I have filed
https://github.com/apache/arrow-datafusion/issues/3304 to track this.
Note that for the Dask SQL usage, we will no longer see any references to
`IsNotDistinctFrom` since that mapping is happening in DataFusion's physical
query planner, which we are not using.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
