avantgardnerio commented on code in PR #3225:
URL: https://github.com/apache/arrow-datafusion/pull/3225#discussion_r959013677
##########
datafusion/proto/src/lib.rs:
##########
@@ -513,7 +513,7 @@ mod roundtrip_tests {
DataType::FixedSizeBinary(1234),
DataType::FixedSizeBinary(-432),
DataType::LargeBinary,
- DataType::Decimal128(1345, 5431),
+ DataType::Decimal128(123, 234),
Review Comment:
We store precision as a u8 now. 234 fits, 455 doesn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
