vibhatha commented on code in PR #13700:
URL: https://github.com/apache/arrow/pull/13700#discussion_r959157793
##########
cpp/examples/arrow/execution_plan_documentation_examples.cc:
##########
@@ -231,15 +231,21 @@ arrow::Result<BatchesWithSchema>
MakeSortTestBasicBatches() {
arrow::Result<BatchesWithSchema> MakeGroupableBatches(int multiplicity = 1) {
BatchesWithSchema out;
auto fields = {arrow::field("i32", arrow::int32()), arrow::field("str",
arrow::utf8())};
- ARROW_ASSIGN_OR_RAISE(auto b1_int, GetArrayDataSample<arrow::Int32Type>({12,
7, 3}));
- ARROW_ASSIGN_OR_RAISE(auto b2_int, GetArrayDataSample<arrow::Int32Type>({-2,
-1, 3}));
- ARROW_ASSIGN_OR_RAISE(auto b3_int, GetArrayDataSample<arrow::Int32Type>({5,
3, -8}));
- ARROW_ASSIGN_OR_RAISE(auto b1_str,
GetBinaryArrayDataSample<arrow::StringType>(
- {"alpha", "beta", "alpha"}));
- ARROW_ASSIGN_OR_RAISE(auto b2_str,
GetBinaryArrayDataSample<arrow::StringType>(
- {"alpha", "gamma", "alpha"}));
- ARROW_ASSIGN_OR_RAISE(auto b3_str,
GetBinaryArrayDataSample<arrow::StringType>(
- {"gamma", "beta", "alpha"}));
+ ARROW_ASSIGN_OR_RAISE(auto b1_int,
+ GetArrayDataSample<arrow::Int32Type>({12, 7, 3, 15,
10, 0, 11}));
+ ARROW_ASSIGN_OR_RAISE(auto b2_int,
+ GetArrayDataSample<arrow::Int32Type>({2, 1, 3, 12, 10,
11, 12}));
Review Comment:
No I think, I added more samples and wanted a rough pattern. Negative
numbers wouldn't harm. Do you want me to revert this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
