pitrou commented on code in PR #13991: URL: https://github.com/apache/arrow/pull/13991#discussion_r959537451
########## r/configure: ########## @@ -208,22 +208,19 @@ if grep raspbian /etc/os-release >/dev/null 2>&1; then PKG_LIBS="-latomic $PKG_LIBS" fi -# If libarrow uses the old GLIBCXX ABI, so we have to use it too -if [ "$ARROW_USE_OLD_CXXABI" ]; then - PKG_CFLAGS="$PKG_CFLAGS -D_GLIBCXX_USE_CXX11_ABI=0" -fi - # Set any user-defined CXXFLAGS if [ "$ARROW_R_CXXFLAGS" ]; then PKG_CFLAGS="$PKG_CFLAGS $ARROW_R_CXXFLAGS" fi +set -ex + Review Comment: I don't know, wouldn't it be better to keep at least the `set -e` so that errors bail out immediately? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
