lidavidm commented on code in PR #57:
URL: https://github.com/apache/arrow-adbc/pull/57#discussion_r959565062
##########
c/driver_manager/adbc_driver_manager.cc:
##########
@@ -705,18 +724,37 @@ AdbcStatusCode AdbcLoadDriver(const char* driver_name,
const char* entrypoint,
#endif // defined(_WIN32)
- auto result = init_func(count, driver, initialized, error);
+ auto result = AdbcLoadDriverFromInitFunc(init_func, count, driver,
initialized, error);
+ if (result != ADBC_STATUS_OK) {
#if defined(_WIN32)
- driver->private_manager = new ManagerDriverState{handle, driver->release};
- driver->release = &ReleaseDriver;
+
#endif // defined(_WIN32)
+ }
Review Comment:
I removed this, but I filed #98 since I think we aren't properly calling
FreeLibrary on Windows in all cases. (There's some dead code further around
L190 that was never wired up).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
