liukun4515 commented on issue #2616: URL: https://github.com/apache/arrow-rs/issues/2616#issuecomment-1232934146
> My opinion on this topic is that there is a tradeoff: > > If you check in the generated file, then the required build tools (e.g. protobuf compiler) are not needed for most developers, thus sometimes simplifying the build environment. However, re-generating the file when changes are made is harder as now the special build tools are required. > > Thus my opinion is that > > * if `arrow-flight` already require the special build tools (e.g. `protoc`) then it would be fine to not check in the generated files. > * However, if `arrow-flight` does **not** currently require `protoc` to be installed, and this change would begin requiring `protoc` I like that less (though I would personally still be ok) > > All the build environments I deal with (Arrow CI, DataFusion CI, IOx CI) all need `protoc` so it wouldn't affect me or my projects personally. I will check that concerned from you. If need the compile tool e.g. `protoc`, we will not delete the generated file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
