paleolimbot commented on code in PR #13706:
URL: https://github.com/apache/arrow/pull/13706#discussion_r959645763
##########
r/R/arrow-package.R:
##########
@@ -81,6 +81,14 @@
invisible()
}
+.onUnload <- function(...) {
+ # When running valgrind we need to wait for the thread pools to finish
+ # running background tasks or else spurious memory leaks may be reported.
+ if (on_linux_dev()) {
Review Comment:
Also see below, but this doesn't fix the memory leak so I removed it.
##########
r/R/query-engine.R:
##########
@@ -238,18 +227,13 @@ ExecPlan <- R6Class("ExecPlan",
slice_size <- node$extras$head %||% node$extras$tail
if (!is.null(slice_size)) {
out <- head(out, slice_size)
- # We already have everything we need for the head, so StopProducing
- self$Stop()
Review Comment:
Test added!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
