westonpace commented on code in PR #13940:
URL: https://github.com/apache/arrow/pull/13940#discussion_r959839513
##########
cpp/src/arrow/compute/exec/key_hash_test.cc:
##########
@@ -35,9 +35,11 @@ namespace compute {
class TestVectorHash {
private:
- static Result<std::shared_ptr<BinaryArray>> GenerateUniqueRandomBinary(
+ template <typename Type, typename ArrayType = typename
TypeTraits<Type>::ArrayType>
+ static Result<std::shared_ptr<ArrayType>> GenerateUniqueRandomBinary(
Review Comment:
Can we add a quick comment (or a template constraint) that `Type` must be a
binary type (e.g. Binary / LargeBinary)? Maybe it should be obvious but I
didn't quite catch it the first glance through.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
