avantgardnerio commented on code in PR #3311:
URL: https://github.com/apache/arrow-datafusion/pull/3311#discussion_r960017681
##########
datafusion/sql/src/parser.rs:
##########
@@ -41,10 +41,7 @@ fn parse_file_type(s: &str) -> Result<FileType, ParserError>
{
"NDJSON" => Ok(FileType::NdJson),
"CSV" => Ok(FileType::CSV),
"AVRO" => Ok(FileType::Avro),
- other => Err(ParserError::ParserError(format!(
- "expect one of PARQUET, AVRO, NDJSON, or CSV, found: {}",
- other
- ))),
+ name => Ok(FileType::Custom(name.to_string()))
Review Comment:
Also, I'd love to use the postgres `with options` syntax to pass an
arbitrary hashmap for credentials, host & port, etc.
https://www.postgresql.org/docs/current/sql-createforeigntable.html
```
CREATE FOREIGN TABLE [ IF NOT EXISTS ] table_name ( [
{ column_name data_type [ OPTIONS ( option 'value' [, ... ] ) ]
```
On second thought, credentials could be controversial... forget I said
that :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
