pitrou commented on code in PR #14019:
URL: https://github.com/apache/arrow/pull/14019#discussion_r960434615


##########
cpp/src/arrow/filesystem/s3_internal.h:
##########
@@ -154,8 +154,9 @@ Status ErrorToStatus(const std::string& prefix, const 
std::string& operation,
   // 
https://sdk.amazonaws.com/cpp/api/LATEST/namespace_aws_1_1_s3.html#ae3f82f8132b619b6e91c88a9f1bde371
   return Status::IOError(
       prefix, "AWS Error ",
-      S3ErrorToString(static_cast<Aws::S3::S3Errors>(error.GetErrorType())), " 
during ",
-      operation, " operation: ", error.GetMessage());
+      S3ErrorToString(static_cast<Aws::S3::S3Errors>(error.GetErrorType())),
+      " (http status ", static_cast<int>(error.GetResponseCode()), ")",

Review Comment:
   Shouldn't we add this only if the AWS error is actually "unknown"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to