paleolimbot opened a new pull request, #40:
URL: https://github.com/apache/arrow-nanoarrow/pull/40

   Fixes #21. Will demonstrate:
   
   - A minimal CMake configuration that builds + privately links a static 
nanoarrow build
   - A minimal vendored configuration
   
   The principles I'd like to communicate are:
   
   - You must vendor nanoarrow.c/nanoarrow.h or privately link a static library
   - You must not expose any parts of nanoarrow.h in one of your library's 
headers (except the ABI stable Arrow C Data/Stream interface)
   - When using the vendored nanoarrow.h/nanoarrow.c version, you should 
`#define NANOARROW_NAMESPACE SomeNamespace` to avoid symbol collisions (i.e., 
if somebody else loads your library into the same process or vendors it into 
another library)
   - Maybe bits I'm missing?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to