alamb commented on PR #3333: URL: https://github.com/apache/arrow-datafusion/pull/3333#issuecomment-1235557949
I will review this in more detail, likely tomorrow morning. On Thu, Sep 1, 2022 at 5:11 PM Brent Gardner ***@***.***> wrote: > @tustvold <https://github.com/tustvold> @alamb <https://github.com/alamb> > What do you two think? This seems (to me) to be the best of all worlds: > > 1. generated code is not checked in > 2. generated code is in source folders so IDEs work again > > The only downside is that protoc is required, but that was already a > requirement for datafusion. If anyone is interested I can (in another > PR), have build.rs download and unzip the appropriate protoc for the > platform. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/arrow-datafusion/pull/3333#issuecomment-1234787188>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AADXZMOFBEEMKESLDLOXYOTV4ELW3ANCNFSM6AAAAAAQCTKVW4> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
