cyb70289 commented on pull request #8269: URL: https://github.com/apache/arrow/pull/8269#issuecomment-700379771
Thanks @nealrichardson > 1. Naming: I've never seen this called `stdev` anywhere. `stddev` is common, in numpy and julia it's `std`, in R it's `sd`. Let's go with one of those. Maybe just add an extra "d"? Naming is always the hardest thing :) Looks `std` is used more often, and it's short. AFAIK, `stdev` is used in excel (the most popular statistic software I guess? :) > 2. Since `sd = sqrt(var)` (https://github.com/apache/arrow/pull/8269/files#diff-461bd7e445c2a190f1173ebdefa21002R106), would it make sense to implement variance (i.e. most of this patch), and then standard deviation as the sqrt of that? That way we get two kernels (or even three, if sqrt is exposed as a kernel too). I also thought about the `var` kernel. Will update this patch to include it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
