[GitHub] [arrow] pitrou commented on a change in pull request #8290: ARROW-10119: [C++] Fix Parquet crashes on invalid input

[GitBox]

pitrou commented on a change in pull request #8290:
URL: https://github.com/apache/arrow/pull/8290#discussion_r496548609



##########
File path: cpp/src/parquet/column_reader.cc
##########
@@ -374,14 +381,10 @@ std::shared_ptr<Page> SerializedPageReader::NextPage() {
 
       page_buffer = decryption_buffer_;
     }
-    // Uncompress it if we need to
-    if (decompressor_ != nullptr) {
-      page_buffer = DecompressPage(compressed_len, uncompressed_len, 
page_buffer->data());
-    }
 
-    const PageType::type page_type = LoadEnumSafe(&current_page_header_.type);
+    current_page_type_ = LoadEnumSafe(&current_page_header_.type);

Review comment:
       Hmm, this was needed in a previous version of this patch, but I'll 
revert.

##########
File path: cpp/src/parquet/column_reader.cc
##########
@@ -391,10 +394,14 @@ std::shared_ptr<Page> SerializedPageReader::NextPage() {
         throw ParquetException("Invalid page header (negative number of 
values)");
       }
 
+      // Uncompress if needed

Review comment:
       Will do :-)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org