avantgardnerio commented on code in PR #3311:
URL: https://github.com/apache/arrow-datafusion/pull/3311#discussion_r962415504
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -1214,19 +1214,6 @@ pub struct CreateView {
pub definition: Option<String>,
}
-/// Types of files to parse as DataFrames
Review Comment:
I started with that solution, but I think it makes more sense to go:
1. enum (as it was)
2. string (with hard-coded values)
3. everything-as-a-TableProviderFactory (string with no hard-coded values)
If this PR is accepted, I will move immediately onto step #3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
