avantgardnerio commented on code in PR #3363:
URL: https://github.com/apache/arrow-datafusion/pull/3363#discussion_r963230434
##########
datafusion-examples/examples/custom_datasource.rs:
##########
@@ -243,8 +243,8 @@ impl ExecutionPlan for CustomExec {
db.data.values().cloned().collect()
};
- let mut id_array = UInt8Builder::new(users.len());
- let mut account_array = UInt64Builder::new(users.len());
+ let mut id_array = UInt8Builder::new();
Review Comment:
I'm happy to put these all back to `with_capacity()`, but now that they take
two parameters, I wasn't sure what to set the `data_size` to. (`item_count` is
straight-forward).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
