viirya commented on code in PR #2650:
URL: https://github.com/apache/arrow-rs/pull/2650#discussion_r963262773
##########
arrow/src/compute/kernels/arity.rs:
##########
@@ -83,6 +84,41 @@ where
PrimitiveArray::<O>::from(data)
}
+/// A overflow-checking variant of `unary`.
+pub(crate) fn unary_checked<I, F, O>(
Review Comment:
I am not sure what you mean to "align with the method `unary`". The `F` of
`unary` doesn't return `Option` or `Result`.
Based on these comments, let me try to guess what you are suggesting, are
you suggesting to change returning type of `F` function parameter to `Result`,
move the overflow `ArrowError::ComputeError` to the arithmetic scalar kernels,
to make this `unary_checked` not only for the these arithmetic kernels?
I'm okay for the change, but where do you think the `unary_checked` will
also be used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
