HaoYang670 commented on issue #3369: URL: https://github.com/apache/arrow-datafusion/issues/3369#issuecomment-1237801067
cc @alamb @andygrove @Dandandan . Need your reviews this will cause some public API changes. The reasons I want to do this are: 1. `skip = None` and `skip = Some(0)` are equivalent, so we don't need both of them. 2. This can avoid bugs in corner cases. While working on `limit_push_down`, I find there are lots of 'map_or, unwrap_or, ' and pattern matching with `return`, which is difficult to read and easy to have bug 3. We don't need to test `skip=None`, just to test `skip=0` is enough. for `Limit::fetch`, we need the type `Optiona<usize>`, because `fetch = None` means fetching all rows, and we cannot express this in `usize` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
