tustvold opened a new pull request, #2666:
URL: https://github.com/apache/arrow-rs/pull/2666
_Draft as needs more testing, docs, etc... but wanted to create for
visibility
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
ArrayIter is great from an ergonomics perspective and definitely something
we should continue to provide to users, however, the way it interleaves null
masks severely makes for pretty poor performance. For primitive arrays, this
can result in orders of magnitude more time spent handling the null mask than
the values themselves.
```
divide time: [75.202 us 75.276 us 75.359 us]
change: [-89.655% -89.644% -89.633%] (p = 0.00 <
0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
3 (3.00%) high mild
2 (2.00%) high severe
divide_nulls time: [92.458 us 92.489 us 92.522 us]
change: [-93.765% -93.754% -93.746%] (p = 0.00 <
0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
1 (1.00%) low severe
1 (1.00%) low mild
4 (4.00%) high mild
2 (2.00%) high severe
modulo_nulls time: [218.79 us 218.85 us 218.92 us]
change: [-72.606% -72.571% -72.509%] (p = 0.00 <
0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
3 (3.00%) low mild
2 (2.00%) high mild
3 (3.00%) high severe
```
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking
change` label.
-->
FYI @viirya @liukun4515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
