alamb commented on code in PR #3254:
URL: https://github.com/apache/arrow-datafusion/pull/3254#discussion_r963811265
##########
datafusion/optimizer/src/type_coercion.rs:
##########
@@ -116,18 +117,61 @@ impl ExprRewriter for TypeCoercionRewriter {
}
}
}
+ Expr::ScalarUDF { fun, args } => {
+ let new_expr = coerce_arguments_for_signature(
+ args.as_slice(),
+ &self.schema,
+ &fun.signature,
+ )?;
+ Ok(Expr::ScalarUDF {
+ fun: fun.clone(),
+ args: new_expr,
+ })
+ }
_ => Ok(expr),
}
}
}
+/// Returns `expressions` coerced to types compatible with
+/// `signature`, if possible.
+///
+/// See the module level documentation for more detail on coercion.
+pub fn coerce_arguments_for_signature(
Review Comment:
I feel like this code should already exist somewhere and it would be great
to consolidate into a single implementation rather than have multiple
implementations around
##########
datafusion/optimizer/src/type_coercion.rs:
##########
@@ -167,4 +211,64 @@ mod test {
\n EmptyRelation", &format!("{:?}", plan));
Ok(())
}
+
+ #[test]
+ fn scalar_udf() -> Result<()> {
+ let empty = empty();
+ let return_type: ReturnTypeFunction =
+ Arc::new(move |_| Ok(Arc::new(DataType::Utf8)));
+ let fun: ScalarFunctionImplementation = Arc::new(move |_|
unimplemented!());
+ let udf = Expr::ScalarUDF {
+ fun: Arc::new(ScalarUDF::new(
+ "TestScalarUDF",
+ &Signature::uniform(1, vec![DataType::Float32],
Volatility::Stable),
+ &return_type,
+ &fun,
+ )),
+ args: vec![lit(123_i32)],
+ };
+ let plan = LogicalPlan::Projection(Projection::try_new(vec![udf],
empty, None)?);
+ let rule = TypeCoercion::new();
+ let mut config = OptimizerConfig::default();
+ let plan = rule.optimize(&plan, &mut config)?;
+ assert_eq!(
+ "Projection: TestScalarUDF(CAST(Int32(123) AS Float32))\n
EmptyRelation",
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
