andygrove commented on code in PR #3365:
URL: https://github.com/apache/arrow-datafusion/pull/3365#discussion_r964066994
##########
datafusion/proto/src/to_proto.rs:
##########
@@ -224,10 +224,12 @@ impl From<&DataType> for
protobuf::arrow_type::ArrowTypeEnum {
fractional: *fractional as u64,
}),
DataType::Decimal256(_, _) => {
- unimplemented!("The Decimal256 data type is not yet supported")
+ unimplemented!("Proto serialization error: The Decimal256 data
type is not yet supported")
Review Comment:
If we used `impl TryFrom` instead of `impl From`, we could return errors
here. This could be done as a separate Pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
