pitrou commented on a change in pull request #8302:
URL: https://github.com/apache/arrow/pull/8302#discussion_r496942764
##########
File path: cpp/src/arrow/ipc/writer.cc
##########
@@ -982,13 +982,7 @@ class ARROW_EXPORT IpcFormatWriter : public
RecordBatchWriter {
RETURN_NOT_OK(CheckStarted());
- if (!wrote_dictionaries_) {
- RETURN_NOT_OK(WriteDictionaries(batch));
- wrote_dictionaries_ = true;
- }
-
- // TODO: Check for delta dictionaries. Can we scan for deltas while
computing
- // the RecordBatch payload to save time?
+ RETURN_NOT_OK(WriteDictionaries(batch));
Review comment:
Ah, we can skip zero-length dictionaries explicitly, but won't it
confuse the IPC reader?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
