dhruv9vats opened a new pull request, #2676: URL: https://github.com/apache/arrow-rs/pull/2676
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes #2188. # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> # What changes are included in this PR? For the operations that only need to know if there are any nulls to select a more optimized code path, we instead of counting nulls in both `lhs` and `rhs` null masks: - Replace `count_nulls` with `contains_nulls` to not have to traverse the whole bitmap once a null is found. - Only check for nulls in `lhs` `ArrayData`'s null mask, as at these points in execution, the null masks have already been compared. <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> # Are there any user-facing changes? No. <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!--- If there are any breaking changes to public APIs, please add the `breaking change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
