vibhatha commented on code in PR #14024:
URL: https://github.com/apache/arrow/pull/14024#discussion_r964736395
##########
cpp/src/arrow/engine/substrait/util.cc:
##########
@@ -107,19 +111,36 @@ class SubstraitExecutor {
bool plan_started_;
compute::ExecContext exec_context_;
std::shared_ptr<SubstraitSinkConsumer> sink_consumer_;
+ const ConversionOptions& conversion_options_;
};
} // namespace
Result<std::shared_ptr<RecordBatchReader>> ExecuteSerializedPlan(
- const Buffer& substrait_buffer, const ExtensionIdRegistry* extid_registry,
- compute::FunctionRegistry* func_registry) {
+ const Buffer& substrait_buffer, const PythonTableProvider& table_provider,
+ const ExtensionIdRegistry* registry, compute::FunctionRegistry*
func_registry) {
Review Comment:
One thing, if we do this, I think we need to expose `Declaration` to Cython.
Because we have to define the `NamedTableProvider` and bind it to the options.
Is that okay?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
