alamb commented on code in PR #3385:
URL: https://github.com/apache/arrow-datafusion/pull/3385#discussion_r964758431
##########
docs/source/user-guide/example-usage.md:
##########
@@ -40,7 +42,7 @@ async fn main() -> datafusion::error::Result<()> {
ctx.register_csv("example", "tests/example.csv",
CsvReadOptions::new()).await?;
// create a plan to run a SQL query
- let df = ctx.sql("SELECT a, MIN(b) FROM example GROUP BY a LIMIT
100").await?;
+ let df = ctx.sql("SELECT \"A\", MIN(b) FROM example GROUP BY \"A\" LIMIT
100").await?;
Review Comment:
I am not sure about changing this code example. When I tried this example
code now using
https://github.com/apache/arrow-datafusion/blob/master/datafusion/core/tests/example.csv
I get an error
```
Running `/Users/alamb/Software/target-iox2/debug/df_test`
Error: SchemaError(FieldNotFound { qualifier: None, name: "A", valid_fields:
Some(["example.a", "example.b", "example.c"]) })
```
Maybe we should add an explicit link to the example.csv file ?
##########
docs/source/user-guide/example-usage.md:
##########
@@ -19,6 +19,8 @@
# Example Usage
+In this example some simple processing is performed on a csv file. Please be
aware that all identifiers are made lower-case in SQL, so if your csv file has
capital letters (ex: Name) you should put your column name in double quotes or
the example won't work.
Review Comment:
This note is great
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
