liukun4515 commented on code in PR #2666:
URL: https://github.com/apache/arrow-rs/pull/2666#discussion_r964843476
##########
arrow/src/compute/kernels/arithmetic.rs:
##########
@@ -211,32 +110,35 @@ where
/// This function errors if:
/// * the arrays have different lengths
/// * there is an element where both left and right values are valid and the
right value is `0`
-fn math_checked_divide_op<T, F>(
- left: &PrimitiveArray<T>,
- right: &PrimitiveArray<T>,
+fn math_checked_divide_op<LT, RT, F>(
+ left: &PrimitiveArray<LT>,
+ right: &PrimitiveArray<RT>,
op: F,
-) -> Result<PrimitiveArray<T>>
+) -> Result<PrimitiveArray<LT>>
Review Comment:
good point.
cc @tustvold I think type of the left and right should be same.
The kernel of arrow will not handle the different data type for computing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
