[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #3374: Use `usize` rather than `Option` to represent `Limit::skip`and `Limit::offset`

Wed, 07 Sep 2022 07:56:23 -0700 


jackwener commented on code in PR #3374:
URL: https://github.com/apache/arrow-datafusion/pull/3374#discussion_r964950206


##########
datafusion/optimizer/src/eliminate_limit.rs:
##########
@@ -82,10 +82,11 @@ fn eliminate_limit(
                     }
                 }
                 None => {
-                    match skip {
+                    if *skip == 0 {
                         // If there is no LIMIT and OFFSET is zero, 
LIMIT/OFFSET can be removed
-                        Some(skip) if *skip == 0 => return 
Ok(input.as_ref().clone()),
-                        _ => {}
+                        return Ok(input.as_ref().clone());
+                    } else {
+                        {}

Review Comment:
   redundant part



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to