alamb commented on code in PR #3381:
URL: https://github.com/apache/arrow-datafusion/pull/3381#discussion_r964974538
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -1430,6 +1430,8 @@ impl PartialEq for Subquery {
}
}
+impl Eq for Subquery {}
Review Comment:
well I suppose `Eq` is satisfied given that PartialEq always returns false
the requirements
https://doc.rust-lang.org/std/cmp/trait.Eq.html
are satisfied in a strange sort of way
##########
datafusion/expr/src/udaf.rs:
##########
@@ -56,6 +56,8 @@ impl PartialEq for AggregateUDF {
}
}
+impl Eq for AggregateUDF {}
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
