kmitchener opened a new pull request, #3393:
URL: https://github.com/apache/arrow-datafusion/pull/3393
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #3392 and closes #166.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
* changed datatypes to match TPC-H definition -- where Float64 was used,
using Decimal128 now
* added special handling of q15 results, where we want to capture the
results of the second of 3 statements
* fixed up the comparison of query results against known-good answers
* stop ignoring q15 and q21
* update README with link to benchmark PDF for reference
Assuming you set the TPCH_DATA env, all the tests now complete successfully
except:
* q6 returns wrong results according to this test
* q9 has at least one row that's off by .01
* q11 "attempt to multiply with overflow" panic
* q14 "attempt to multiply with overflow" panic
* q17 "attempt to multiply with overflow" panic
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
