ManManson commented on PR #13804: URL: https://github.com/apache/arrow/pull/13804#issuecomment-1239726259
Force-pushed the branch to address review comments. The diff can be found there: https://github.com/apache/arrow/compare/a6c5d5075b8150cf4ecf6874ad59a0e8497af93c..b47679f0708ed736e75c0254f5654cae9d9abbe4 Changelog: * Fixed include style, reordered includes * `GetFragmentsAsyncImpl()` accepts a `executor` argument, defaulting to `GetCPUThreadPool()` in the default implementation of `Dataset` class * Fixed a bug in `DatasetFixtureMixin::AssertFragmentEquals()` which incorrectly assumed that the fragment scanner would always drain the batch generator * Added a test for `Dataset::GetFragments` by utilizing the `AssertDatasetFragmentsEqual()` helper, which was unused until now * Added a similar test for `Dataset::GetFragmentsAsync` along with a similar helper `DatasetFixtureMixin::AssertDatasetAsyncFragmentsEqual()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
