pitrou commented on code in PR #14043:
URL: https://github.com/apache/arrow/pull/14043#discussion_r965741208
##########
cpp/src/arrow/compute/function.h:
##########
@@ -225,6 +233,15 @@ class ARROW_EXPORT Function {
/// required by the kernel.
virtual Result<const Kernel*> DispatchBest(std::vector<TypeHolder>* values)
const;
+ /// \brief Get a function executor with a best-matching kernel
+ virtual Result<std::shared_ptr<FunctionExecutor>> BestExecutor(
Review Comment:
Naming-wise, a method which does something non-trivial (as opposed to a
simple accessor) should probably be described with a verb, so e.g.
`GetBestExecutor`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
