[GitHub] [arrow] drin commented on a diff in pull request #14071: ARROW-16424: [C++] Use Uri to parse substrait ReadRel file path

[GitBox]

drin commented on code in PR #14071:
URL: https://github.com/apache/arrow/pull/14071#discussion_r966245989


##########
cpp/src/arrow/engine/substrait/relation_internal.cc:
##########
@@ -52,159 +55,239 @@ Status CheckRelCommon(const RelMessage& rel) {
   return Status::OK();
 }
 
-Result<DeclarationInfo> FromProto(const substrait::Rel& rel, const 
ExtensionSet& ext_set,
-                                  const ConversionOptions& conversion_options) 
{
-  static bool dataset_init = false;
-  if (!dataset_init) {
-    dataset_init = true;
-    dataset::internal::Initialize();
+Status CheckReadRelation(const substrait::ReadRel& rel,

Review Comment:
   I removed this as part of backing out the re-organization. I will include it 
in a subsequent PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org