tustvold commented on code in PR #2593: URL: https://github.com/apache/arrow-rs/pull/2593#discussion_r966428417
########## arrow/src/row/variable.rs: ########## @@ -0,0 +1,97 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use crate::compute::SortOptions; +use crate::row::Rows; +use crate::util::bit_util::ceil; + +/// The block size of the variable length encoding +pub const BLOCK_SIZE: usize = 32; + +/// Returns the length of the encoded representation of a byte array +pub fn encoded_len(a: Option<&[u8]>) -> usize { + match a { + Some(a) => 1 + ceil(a.len(), BLOCK_SIZE) * (BLOCK_SIZE + 1), + None => 1, + } +} + +/// Variable length values are encoded as +/// +/// - leading `0` bit if null otherwise `1` +/// - 31 bits big endian length Review Comment: Yeah this docstring is outdated, I switched to a block encoding -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
