alamb commented on a change in pull request #8303:
URL: https://github.com/apache/arrow/pull/8303#discussion_r497420626
##########
File path: rust/arrow/src/array/array.rs
##########
@@ -1267,6 +1267,36 @@ impl<OffsetSize: OffsetSizeTrait>
GenericBinaryArray<OffsetSize> {
GenericBinaryArray::<OffsetSize>::from(array_data)
}
+ fn from_opt_vec(v: Vec<Option<&[u8]>>, data_type: DataType) -> Self {
Review comment:
This turned out to be a great call @jorgecarleitao -- I found a bug in
this implementation while writing a test. Thank you for the suggestion. 💯
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
